rcs_rename and rcs_remove also were in the big mercurial patch
[ikiwiki.git] / doc / todo / rcs__95__diff_implementation_for_Mercurial_backend__44___based_on_Git_backend.mdwn
1 (**Note:** this patch is built on top of [[Attempt to extend Mercurial backend support]] and [[rcs__95__get__123__c__44__m__125__time_implementation_for_Mercurial_backend__44___based_on_Git_backend]]. The former is needed for the `safe_hg()` definition. The latter only shows up in the very last line matching of this patch.)
2
3 CC of `rcs_diff` implementation in `git.pm` with few changes. Mercurial provides the `hg diff -g` switch, which outputs the diff in Git-format, making the implementation easy. I think it's a good idea to base `mercurial.pm` as much as possible om `git.pm` to simplify and be able to benefit from the maintenance of `git.pm`, which probably is more used.
4
5 [Patch at my hg repo](http://510x.se/hg/program/ikiwiki/diff/cc73d670bf99/Plugin/mercurial.pm) ([raw format](http://510x.se/hg/program/ikiwiki/raw-file/cc73d670bf99/Plugin/mercurial.pm)).
6
7 --[[Daniel Andersson]]
8
9 ---
10
11         diff -r 1b6c46b62a28 -r cc73d670bf99 Plugin/mercurial.pm
12         --- a/Plugin/mercurial.pm       Tue Jul 19 13:35:17 2011 +0200
13         +++ b/Plugin/mercurial.pm       Tue Jul 19 13:35:37 2011 +0200
14         @@ -307,7 +307,23 @@
15          }
16          
17          sub rcs_diff ($;$) {
18         -       # TODO
19         +       my $rev=shift;
20         +       my $maxlines=shift;
21         +       my @lines;
22         +       my $addlines=sub {
23         +               my $line=shift;
24         +               return if defined $maxlines && @lines == $maxlines;
25         +               push @lines, $line."\n"
26         +                       if (@lines || $line=~/^diff --git/);
27         +               return 1;
28         +       };
29         +       safe_hg(undef, $addlines, "hg", "diff", "-c", $rev, "-g");
30         +       if (wantarray) {
31         +               return @lines;
32         +       }
33         +       else {
34         +               return join("", @lines);
35         +       }
36          }
37          
38          {