]> sipb.mit.edu Git - ikiwiki.git/blob - doc/bugs/html5_time_element__39__s_pubdate_wrong_when_using_xhtml5___34__mode__34__.mdwn
Merge remote branch 'origin/master'
[ikiwiki.git] / doc / bugs / html5_time_element__39__s_pubdate_wrong_when_using_xhtml5___34__mode__34__.mdwn
1 Hi,
2
3 XML error:
4
5     Created <time datetime="2009-03-24T18:02:14Z" pubdate class="relativedate" title="Tue, 24 Mar 2009 14:02:14 -0400">2009-03-24</time>
6
7 The pubdate REQUIRES a date, so e.g. `pubdate="2009-03-24T18:02:14Z"`
8
9 Otherwise the XML parser chokes.
10
11 <http://www.whatwg.org/specs/web-apps/current-work/multipage/text-level-semantics.html#attr-time-pubdate>
12
13 (indented exactly 4 spaces)
14
15 <pre>
16     diff --git a/IkiWiki.pm b/IkiWiki.pm
17     index 1f2ab07..6ab5b56 100644
18     --- a/IkiWiki.pm
19     +++ b/IkiWiki.pm
20     @@ -1004,7 +1004,7 @@ sub displaytime ($;$$) {
21         my $time=formattime($_[0], $_[1]);
22         if ($config{html5}) {
23             return '&lt;time datetime="'.date_3339($_[0]).'"'.
24     -         ($_[2] ? ' pubdate' : '').
25     +           ($_[2] ? ' pubdate="'.date_3339($_[0]).'"' : '').
26                 '>'.$time.'&lt;/time&gt;';
27         }
28         else {
29     diff --git a/IkiWiki/Plugin/relativedate.pm b/IkiWiki/Plugin/relativedate.pm
30     index fe8ef09..8c4a1b4 100644
31     --- a/IkiWiki/Plugin/relativedate.pm
32     +++ b/IkiWiki/Plugin/relativedate.pm
33     @@ -59,7 +59,7 @@ sub mydisplaytime ($;$$) {
34      
35         if ($config{html5}) {
36             return '&lt;time datetime="'.IkiWiki::date_3339($time).'"'.
37     -         ($pubdate ? ' pubdate' : '').$mid.'&lt;/time&gt;';
38     +           ($pubdate ? ' pubdate="'.IkiWiki::date_3339($time).'"' : '').$mid.'&lt;/time&gt;';
39         }
40         else {
41             return '&lt;span'.$mid.'&lt;/span&gt;';
42 </pre>